search

pulseaudio-equalizer-ladspa / equalizer

Pulseaudio LADSPA Equalizer
GNU General Public License v3.0
138 stars 15 forks source link

Redesign #10

Closed rautesamtr closed 5 years ago

rautesamtr commented 5 years ago

This is the PR for the redesign presented in issue #4. The goal of this first iteration is to modernize the user interface without changing any of the core functionality to much.

The one breaking change is the removal of the Apply Settings button which now gets applied automatically after 500ms of no change to any of the equalizer scale values. The reason to use the timer has been that the ApplySettings() function is not atomic enough to just apply changes to the control values. Calling ApplySettings for every value-changed signal would cause the user interface to lag.

This PR builds uppon #9

FFY00 commented 5 years ago

Please resolve the conflicts.

git rebase --interactive master

Then fix the conflicts in the files, and:

git add data/com.github.pulseaudio-equalizer-ladspa.Equalizer.gresource.xml data/ui/Equalizer.ui pulseeq/equalizer.py
git rebase --continue
rautesamtr commented 5 years ago

Looks like i shouldn't do PRs that are based on a branch i made a previous PR with. Sorry for that. A simple rebase on master fixed it.

FFY00 commented 5 years ago

Eh, in small projects like this the conflicts are usually pretty easy to resolve.