search

pulseaudio-equalizer-ladspa / equalizer

Pulseaudio LADSPA Equalizer
GNU General Public License v3.0
138 stars 15 forks source link

Allow the user to add more bands when editing a preset? #17

Open FFY00 opened 5 years ago

FFY00 commented 5 years ago

Should allow a user to add more bands when editing a preset, as well as to change the frequency value of the current ones? I don't know if that's something we want to do as it would complicate the UI.

Perhaps we could add "New Preset" button and query the user on the no of bands there?

FFY00 commented 5 years ago

@raetiacorvus what do you think?

rautesamtr commented 5 years ago

It sounds great but it also means we have to add support for plugins supporting this (see my comment #16).

An approach for supporting more plugins could be to add specialized control widgets per plugin. e.g. mbeq doesn't allow to change frequencies or number of the bands while a short google shows there exist some parametric equalizers where it should be possible to change the frequency of the bands.

FFY00 commented 5 years ago

What kind of specialized UI do we need? Do we need anything other than an editable frequency field and perhaps a way to dynamically add more bands (if we can find an easy and simple way to do it)?

rautesamtr commented 5 years ago

Yes. Sorry i think i wasn't able to express myself correctly. What i had in mind with specialization was more on the level a base gtk container type per plugin that than handles stuff correctly for it. e.g. 15 fixed frequency scales for mbeq_1197. And like you said editable frequency field and a way to dynamically add more bands for a ladspa plugin that supports it.

FFY00 commented 5 years ago

Sounds good to me!

I gonna take this opportunity to explain my current place in the development. I never did GTK+ with Python, I mean it really shouldn't be hard but I never actually needed to do anything like that. You seem very comfortable and happy to help and I didn't really felt the need to touch the python code. However, I feel kinda weird for you doing all the work. So, if you ever need me to make any change in the python code, just let me know. Right now I am just doing some project management and maintaining the bash code but I want you to know you have my full support if you want me to also maintain the python code :grin:.

DwarfFighterCleric commented 4 years ago

Just wanted to say thank you for this application, it's one of those little things that change the experience dramatically for the better! Had been using this EQ daily for the past 3 years, it's specially useful for making laptop speakers louder (and less harsh mids) and for different brands of earphones (different presets for different phones and even for different music albums) Just a huge thank you