pulseaudio-equalizer-ladspa / equalizer

Pulseaudio LADSPA Equalizer
GNU General Public License v3.0
139 stars 15 forks source link

python shebang: should it use env? #32

Open caio96 opened 5 years ago

caio96 commented 5 years ago

System: Manjaro xfce. I'm a user of anaconda, so when a run /usr/bin/pulseaudio-equalizer-gtk it tries to use anaconda's python and it fails because it doesn't have the correct dependencies installed.

Changing #!/usr/bin/env python3 for #!/usr/bin/python3 did the trick.

It should translate to a change in bin/pulseaudio-equalizer-gtk.in: #!/usr/bin/env python@python_major_ver@ for #!/usr/bin/python@python_major_ver@

I don't know if there is any need to use env but this is my suggestion.

FFY00 commented 5 years ago

Doing this would hardcode thus breaking compatibility with virtual environments. It looks to me like your python/anaconda environment is wrongly setup. From the AUR package I see that probably you need to run source /opt/anaconda/bin/deactivate root before running the equalizer. Perhaps you have added anaconda to the environment variables? If so, that's wrong, you should use a virtual environment instead.