pulseaudio-equalizer-ladspa / equalizer

Pulseaudio LADSPA Equalizer
GNU General Public License v3.0
135 stars 15 forks source link

Make the equalizer a sink #37

Open memeplex opened 5 years ago

memeplex commented 5 years ago

The current approach is OK for a static configuration but it's unnatural and almost impossible to get working without tinkering with pa events once you move to a more dynamic setting. Nowadays Bluetooth devices come and go all the time. There are also removable USB cards.

The problem is that being a filter that sits on top of the current default sink makes the equalizer fail every time the current card is removed (because of USB disconnection or whatever). The natural approach would be to make the equalizer a sink that connects to the main card (this should be a parameter, though) and stays there forever, providing an equalized sink for every client wanting to get equalized output, sink which could also be made the default for the system if so desired. I still remember this was the approach to equalization in the good old ALSA days.

Now, I'm not suggesting to completely remove the "as filter" feature, but just saying that the default should be a new "as sink" behavior, which is what most users want for sure.

memeplex commented 5 years ago

This is obviously related to https://github.com/pulseaudio-equalizer-ladspa/equalizer/issues/25

ranolfi commented 4 years ago

When I tried this equalizer it also failed whenever a sink-input with a different sample rate than the previous one was started. (I have alternate-sample-rate and avoid-resampling in daemon.conf.) This is probably related as well.