rautesamtr commented 5 years ago

Hi i am working on a tentative gnome 3 redesign of the application. This issue is more of a question if upstream is even interested in one or not.

Original design for comparison. original_window

What I tried to do with this redesign is to get rid of the controls to the right of the equalizer panel and the advanced menu and move them either to the headerbar or the app menu to be more consistent with the rest of a modern gnome 3 desktop.

redesign_flat_off

app-menu

Both Keep Settings and Reset to defaults have moved to the app menu. I think Keep Settings is fine there. I am not really happy with the Reset to defaults option in general since it is pretty unclear to the user what gets reseted and what not. For now i want to keep it there till better more specific options are provided (e.g. reset option for preset changes that haven't been saved yet).

Changing EQ Enabled to a switch and moving it to the top right is consistent in how gnome-tweaks and gnome-control-center solved this for enabling/disabling a panel altogether. This also makes the window title displaying this state obsolete.

The explicit Apply Settings option has been removed. It was mostly useful to apply changed equalizer scales while in many other cases the application applies those settings automatically. The app now automatically applies settings on the button and key release events on the scales.

The presets text combobox is now the custom title of the headerbar. In theory this is great but has one big problem that it inherits from the original design. The popover isn't scrollable and will ignore your screen boundaries making some options not selectable if you have a long list of presets. Long term it probably needs a customized combobox widget with a custom model. This would also make it possible to display additional information in the list e.g. if preset is a system or a user one. A rework of the presets into a proper class would probably be helpful here.

Both the Save Preset button and Remove user preset… option from the advanced menu are now preset sensitive buttons in the headerbar.

User presets can now be deleted directly when selected allowing to get rid of the filechooser dialog based system.

The save system works still like in the original app with all its flaws. It still isn't possible to overwrite an existing user preset. Typing the name of an existing preset will load it and overwrite any previously made changes.

e.g. assume you start with the Perfect EQ preset, after you change any scale the preset field will be empty and would fail silently if you try to save it without a name. Now you want to name your preset Perfect EQ personalized but once you typed Perfect EQ that preset would load and overwrite any changes you made.

I dabbled around with changing the save system but i think that it would be better to postponed after the presets and presets combobox have been reworked.

redesign_flat_custom

redesign_flat_custom_saved

FFY00 commented 5 years ago

Great to hear! Upstream is abandoned so I don't think they would have any interest. We could keep the project maintained the best we can. I could perhaps create an organization for this.

rautesamtr commented 5 years ago

Sounds good to me.

FFY00 commented 5 years ago

I invited you, I'll give you write access but we should still create pull requests to allow the other members to review the changes.

rautesamtr commented 5 years ago

10 solves this for now

DwarfFighterCleric commented 4 years ago

I use this app daily for 3 years (the old regular version displayed above) I don't think it's useful "applying changes" immediately like you said, because by doing this the user can't notice the differences compared to before changing them, which in the end would make usability harder. That's my 2 cents. And I still don't understand exactly what the "Keep Settings" button does exactly after all this time, I mostly never use it xDDD

pulseaudio-equalizer-ladspa / equalizer

Redesign #4

10 solves this for now