search

pulseaudio-equalizer-ladspa / equalizer

Pulseaudio LADSPA Equalizer
GNU General Public License v3.0
138 stars 15 forks source link

Equalizer won't start #42

Closed mmtj closed 4 years ago

mmtj commented 4 years ago

After latest changes in commit f7e1765 pulseaudio-equalizer won't start and stop on following stacktrace:

Getting settings...
Getting settings...
Traceback (most recent call last):
  File "/usr/local/lib64/python3.7/site-packages/pulseeq/equalizer.py", line 349, in do_startup
    self.window = Equalizer(application=self)
  File "/usr/local/lib64/python3.7/site-packages/pulseeq/equalizer.py", line 302, in __init__
    scale.set_value(float(ladspa_controls[x]))
ValueError: could not convert string to float: 
Getting settings...
Traceback (most recent call last):
  File "/usr/local/lib64/python3.7/site-packages/pulseeq/equalizer.py", line 367, in do_activate
    self.window = Equalizer(application=self)
  File "/usr/local/lib64/python3.7/site-packages/pulseeq/equalizer.py", line 302, in __init__
    scale.set_value(float(ladspa_controls[x]))
ValueError: could not convert string to float:

Latest release 3.0.2 works fine.

Culprit lies in latest changes in handling of variables in pulseaudio-equalizer script.

https://github.com/pulseaudio-equalizer-ladspa/equalizer/commit/f7e176533b1039fa355949e22b6e77727ee14cfc#diff-d860455b216e068fc7f2f55c34a6c3dfR76 https://github.com/pulseaudio-equalizer-ladspa/equalizer/commit/f7e176533b1039fa355949e22b6e77727ee14cfc#diff-d860455b216e068fc7f2f55c34a6c3dfR87

Previous way of replacing spaces with commas through sed somehow trimmed leading space, but now leading space in variables ($RAWDATA1, $RAWDATA2) remains. This will corrupt equalizerrc to the point that pulseaudio-equalizer-gtk is not able to start.