search

pulsejet / memories

Fast, modern and advanced photo management suite. Runs as a Nextcloud app.
https://memories.gallery
GNU Affero General Public License v3.0
2.95k stars 78 forks source link

Choice whether to allow or not download in shared albums #1027

Open clamyahoo opened 5 months ago

clamyahoo commented 5 months ago

Is your feature request related to a problem? Please describe. When I share an album with a public link, I don't always want people to be able to download the photos. But if somebody opens the link, there is the download button displayed with the photos.

Describe the solution you'd like In the Photos App, the download button isn't displayed. So somehow it should be possible to hide it and the best thing would be if the user who shares the album had the choice to hide the button just like he can with normal files in Nextcloud. And - for the records: In the Photos App, the receiver of shared photos can download single photos. This should be regularized as well.

Describe alternatives you've considered Actually, if I want less photos to be downloaded, I share an album of Photos App. If I want no photos to be downloaded, I copy the whole album in a folder and share it blocking the download permission. But all this together is a bit weird. When it is finished, it should be possible in one place, shouldn't it?

Thank you very much and kind regards

Miswu13 commented 3 months ago

I see this as a bug, not as a feature request. I can confirm that even if in the sharing options of the album, the download option is unticked, in the memories app the download button is still present. I don't think that this should be the normal use case.

pulsejet commented 3 months ago

Where are these sharing options you're referring to?

Miswu13 commented 3 months ago

Nextcloud - > Files - > Sharing - > add user to share participants - > Custom permisions for that user - > Checkbox Allow download (see screenshot). I'm using nextcloud Aio v8.0.0, with Nextcloud Hub 7 (28.0.3), and Memories 7.0.2. Android Memories app version is 1.7 20240325_082616

pulsejet commented 3 months ago

@Miswu13 this is unrelated. You are referring to folder shares, where there might indeed be a bug (shared files aren't treated as special, so this could be non-trivial to fix; besides it only "hides" the download button but the user can still download).

This issue is about album shares, particularly public links. This is completely different from folders.

Miswu13 commented 3 months ago

Sorry, my bad. I misunderstood the topic. For public links, I already have disabled the buttons, as well as disabling right click. My only problem was the application download button. Hopefully it will be fixed in the next release. Thank you for your time and patience.

nkinkade commented 1 month ago

I agree that it would be nice to be able remove/hide the big "Download" button on shared albums. Some albums may potentially have dozens of gigabytes of photos (or more), and generally speaking nobody needs to download thousands of photos at once from a large album. I can see the utility of the feature for smaller albums, so, if possible, ideally it would be a per-album option whether to display the button or not.

I understand that even if the link is removed/hidden it may still be possible for someone to manually craft the download URL, as this may be some default feature of how the Photos app has implemented albums. That said, I think it would be sufficient to simply not display the button, since only more sophisticated users will know that this is even a possibility.