search

pulsejet / memories

Fast, modern and advanced photo management suite. Runs as a Nextcloud app.
https://memories.gallery
GNU Affero General Public License v3.0
2.79k stars 73 forks source link

iOS Safari display issues #1092

Open ChildLearningClub opened 1 month ago

ChildLearningClub commented 1 month ago

Describe the bug

You will notice two separate things that could be fixed

  1. Landscape mode not taking up entire screen
  2. When changing from landscape to portrait bottom is cut, requiring refresh of page to fix.

To Reproduce

Share and open public link on iOS Safari

Screenshots

Quick comparison of both Photos and Memories public link displaying on iOS Safari

https://github.com/pulsejet/memories/assets/25701774/9288395a-5764-49be-9b0f-673d1b6f65bd

Platform:

iOS Safari

Additional context

Although not the same issue as Fullscreen not working, but related I think https://github.com/pulsejet/memories/issues/697

pulsejet commented 1 month ago

Safari 😭

pulsejet commented 1 month ago

One note:

Landscape mode not taking up entire screen

This is kinda intentional; that gap is the scroller (same as desktop). Maybe it might make more sense to never show the scroller on mobile devices, but it's not clear what's the better interface on e.g. iPads say with a mouse

ChildLearningClub commented 1 month ago

One note:

Landscape mode not taking up entire screen

This is kinda intentional; that gap is the scroller (same as desktop). Maybe it might make more sense to never show the scroller on mobile devices, but it's not clear what's the better interface on e.g. iPads say with a mouse

Oh I was referring to the URL bar and other open tabs becoming visible when changing to landscape, you will notice in the video that this does not happen with the Photos app.

pulsejet commented 1 month ago

When changing from landscape to portrait bottom is cut, requiring refresh of page to fix.

So I did manage to reproduce this intermittently, but it seems like a bug in Webkit. Safari is actually calling ResizeObserver callbacks with wrong heights, and some of the subsequent calls get dropped for whatever reason; either way this seems like something Apple needs to fix

ChildLearningClub commented 1 month ago

I’m curious why this doesn’t happen with again the Photos app for example?

pulsejet commented 1 month ago

Implemented a possibly unrelated fix; I can't reproduce the issue anymore (though it was sporadic for me to begin with)

I’m curious why this doesn’t happen with again the Photos app for example?

Photos uses a completely different (and much simpler) design -- it plays a bit nicer with the browser but is much slower and doesn't support lazy loading.