Escape shortcut doesn't work when the info tab is opened

pulsejet / memories

Fast, modern and advanced photo management suite. Runs as a Nextcloud app.

https://memories.gallery

GNU Affero General Public License v3.0

2.82k stars 76 forks source link

Escape shortcut doesn't work when the info tab is opened #1115

Open AiroPi opened 1 month ago

AiroPi commented 1 month ago

Describe the bug When the 'informations' panel is open, the escape keyboard shortcut don't quit the photo view anymore.

To Reproduce Open a photo in full screen, click the "informations" button. The escape shortcut doesn't work.

Platform:

OS: MacOS 14.4
Browser: Arc (Chromium Engine Version 123.0.6312.87)
Memories Version: 7.1
Nextcloud Version: 28.0.3

Additional context The shortcut works if the informations tab is not open.

pulsejet commented 1 month ago

Upstream bug https://github.com/nextcloud-libraries/nextcloud-vue/blob/78d9e5d5b36018bbc3e75bbe3a3faa7ac307c21d/src/components/NcAppSidebar/NcAppSidebar.vue#L382C35-L382C47

AiroPi commented 1 month ago

It's fixed now, thanks!

AiroPi commented 1 month ago

Ok, it seems that it is not totally fixed. If we view a photo and then open the info tab, the esc shortcut works. If we view a photo with the info tab already enabled, the esc shortcut also works. But if we have the info tab opened, and we switch to another photo with a an arroy key, the esc shortcut doesn't work.

pulsejet commented 1 month ago

The upstream patch just got merged, we still need to migrate to the new version

AiroPi commented 1 month ago

Ok then some cases were already working as expected before the patch and I didn't notice, my bad

pulsejet commented 1 month ago

Hmm so this is actually not in our hands, the patch needs to be used upstream (in nextcloud/server) before it becomes effective. Guess theres not much to do but wait.