pulsejet / memories

Fast, modern and advanced photo management suite. Runs as a Nextcloud app.
https://memories.gallery
GNU Affero General Public License v3.0
2.95k stars 78 forks source link

Inconsistency when editing date/time metadata of same 'opened' file multiple times #1194

Open siccovansas opened 1 month ago

siccovansas commented 1 month ago

Describe the bug Editing date/time metadata of the same file multiple times results in editing the metadata of other files. I guess this happens because after changing the date/time metadata of a file, the order of the files is immediately changed, but apparently not in the 'slideshow' view?

To Reproduce

  1. Go to a folder with multiple photos
  2. Open the last photo
  3. Click on the 'i' in the top right to open the side panel
  4. In the side panel edit the date/time
  5. In the side panel edit the date/time again (you should see the date/time you entered in step 4, so this looks fine)
  6. In the side panel edit the date/time a third time (you now see the date/time of the new last photo in the folder; when you save it you have actually edited the metadata of this new last photo instead of the original photo that you openend and are still seeing on screen!)

Platform:

Additional info: A same kind of problem happens when you move to the next/previous photo after editing the date/time metadata and also start to edit its date/time metadata.

pulsejet commented 1 month ago

Fixing this is non-trivial but at least the displayed photo should be the correct one with https://github.com/pulsejet/memories/commit/bb1e8612ee3ced849b916ee1fb3fc2e825ef891a.