search

pulsejet / memories

Fast, modern and advanced photo management suite. Runs as a Nextcloud app.
https://memories.gallery
GNU Affero General Public License v3.0
3.17k stars 86 forks source link

Shared Galery Rename or Move Only user "xy" can update this person #290

Open apg1980 opened 1 year ago

apg1980 commented 1 year ago

i open this ticket in case of the developers on the recognize app, told me this is an memories issue. https://github.com/nextcloud/recognize/issues/545

Which version of memories are you using?

4.9.2 Enabled Modes

Object recognition, Face recognition TensorFlow mode

Normal mode Which Nextcloud version do you have installed?

25.0.2 Which Operating system do you have installed?

Ubuntu 22.04 Which Docker container are you using to run Nextcloud? (if applicable)

How much RAM does your server have?

12gb What processor Architecture does your CPU have?

x64 Describe the Bug

I share my whole image galery with my wife and she is uploading her images in this galery as well. facerecoginition with my account quits the option for move faces to another cluster or rename the cluster with "Only user "xx" can update this person". This appears by images uploadet and created from user of my wife in my galery share. I cannot manage my galery´s faces anymore. any tips appreciate

to descrive my issue more detailed. i have on my account an folder names Galery which is shared with my wife (fullpermissions). i am uploading from nextcloud app images and videos via auto upload and my wife up to this folder as well. with the latest 2 versions of recognize or i dont know the nextcloud 25.0.2 i cannot move recognized persons to another cluster if my wife shot those images. the error in the topic appears. if i try to move the images to another cluster from my wifes account i got an error move of image xy failed. no further entrys in the log. this is an serious issue for me i cannot organize my structure anymore. are here any tips?

best regards Expected Behavior

able to move or rename faces

pulsejet commented 1 year ago

So, faces in recognize are owned by users rather than according to the folder. As a result, this is impossible to fix.

A possible solution would be to use external storage or a group folder instead, where everything is owned by a common user. Ideally though, we need a better solution, e.g. shared ownership of files that recognize recognizes (wink).

jerrac commented 1 year ago

Er, I started watching this issue because I was running into that message on pictures stored in a group folder. As in a folder created by the Group folders app.

Do you know if those folders are implemented the same way as normal shared folders?

apg1980 commented 1 year ago

pictures are stored in my account. folder with images are shared to my wife in which she is uploading images as well.

pulsejet commented 1 year ago

Er, I started watching this issue because I was running into that message on pictures stored in a group folder. As in a folder created by the Group folders app.

Hmm, then I incorrectly assumed group folders have common ownership.

pictures are stored in my account. folder with images are shared to my wife in which she is uploading images as well.

So as I said, this is problematic. If Alice owns some photos and Bob owns others, then Alice will have some clusters, Bob will have other clusters, and you can't mix between these now.

Somebody needs to take a closer look at this.

EVOTk commented 1 year ago

If two clusters have the same "name", wouldn't it be possible to display them in the same "folder" and then propose the all cluster with same name ?

Exemple : image

image

image

I don't know if I understand, sorry i'm french, but the idea is that when two clusters have the same name, Memories will make a sub-category, and then display the clusters of each user

apg1980 commented 1 year ago

the latest version after scan over all images and users, displays now each cluster twice, on cluster is from my wifes account (with my shares folder) an one from me, the ones from my wifes account i cannot move and the error appears.

EVOTk commented 1 year ago

the latest version after scan over all images and users, displays now each cluster twice, on cluster is from my wifes account (with my shares folder) an one from me, the ones from my wifes account i cannot move and the error appears.

Yes, it's recognize behavior changed https://github.com/pulsejet/memories/issues/500

apg1980 commented 1 year ago

oh no thats not good to See everything twice, not sexy

EVOTk commented 1 year ago

Yes @pulsejet seems to be working on a way to make it more attractive: https://github.com/pulsejet/memories/issues/462

apg1980 commented 1 year ago

hmmm, i think the same ressource even if its shared should not show everything twice in case of the same content realted to each user which has access to that medias.

pulsejet commented 1 year ago

This is fixed in 4.12.4

EVOTk commented 1 year ago

After the update, the clusters of other users who share photos with me have completely disappeared

pulsejet commented 1 year ago

Maybe you need to run some recognize command. Basically all clusters and detections are now replicated across all users, and you see only your own clusters.

vwbusguy commented 5 months ago

I am still seeing clusters of other users in memories that I can't update/rename. I tried a force reindexing and am still seeing this. They aren't clusters I see in facerecognition but clusters associated with another user that are still showing up in Memories for my user.

Memories: 7.3.1 FaceRecognition: 0.9.50 Nextcloud: 29.0.1

image