search

pulsejet / memories

Fast, modern and advanced photo management suite. Runs as a Nextcloud app.
https://memories.gallery
GNU Affero General Public License v3.0
3.12k stars 83 forks source link

Edit option only available for non-live photos #456

Open meichthys opened 1 year ago

meichthys commented 1 year ago

Currently the Edit button is only available for photos that are not 'live photos'. I find myself looking for the edit button often for live photos which doesn't exist.

It would be nice to be able to edit 'live' photos.

I could be wrong, but AFAIK, the only think linking live photos with their respective videos are some kind of UUID (or some apps just use identical file names). If this is the case, then it seems like it would be possible to allow editing of the photo portion of the live photo.

pulsejet commented 1 year ago

It's disabled on purpose.

  1. Editing the photo part would screw up the video part. E.g. if you cropped it or rotated it, then we either need to edit the video too (almost impossible) or it would not make sense.
  2. Google stores the live video inside the JPEG file. Editing this kind of file would nuke the video.
meichthys commented 1 year ago

Ok thanks for the explanation. I forgot the google video is baked in.

I guess the only option would be to warn the user that the video will be destroyed if the photo is edited. iOS does this when trying to edit a Live Photo:

image

pulsejet commented 1 year ago

Interesting, this could probably be something to consider.

meichthys commented 1 year ago

For reference, this is the current toast notification when trying to edit a live photo: image

daridler commented 6 months ago

I would also suggest a feature to remove the live photo part from the picture. Then editing would be possible.

And I have quite often the situation that my mobile records a live photo but the captured video is useless. So a quick option to remove the video part would be appreciated.