pulsejet / memories

Fast, modern and advanced photo management suite. Runs as a Nextcloud app.
https://memories.gallery
GNU Affero General Public License v3.0
3.19k stars 86 forks source link

Permissions on shared albums #530

Open xlemassacre opened 1 year ago

xlemassacre commented 1 year ago

Is your feature request related to a problem? Please describe. At the moment every user/group that has access to a shared album can also remove/add photos to that album

Describe the solution you'd like Set permissions (read, add, delete) on a shared album on user/group level

Additional context I use the shared album feature for family albums, which is really amazing! It would be even better with the possibility to set permissions :)

meichthys commented 1 year ago

@xlemassacre I agree that shared albums would be a nice improvement, but in the mean time, if you need something asap, you should be able to use shared folders. On folders you have much more fine-grained permissions.

xlemassacre commented 1 year ago

Thanks for the tip, that could help in the meantime, I'll have a look at it. Probably i'll still stick with albums because it's so easy to handle

komoricodrutz commented 10 months ago

Yes, such an option to share an album with "internal" nextcloud users and being able to grant them read-only access but at the same time allowing the shared albums to show up in their Memories app would be extremely beneficial. Especially when you have some very IT-illiterate users, who might ruin something by mistake. The album feature is a lot better for sharing such content. And in such a context, you don't actually need very fine-grained permissions. Just a toggle to disallow editing permissions. Also especially helpful if your family is using the Android companion app. LE: There is a similar feature request for the nextcloud native Photos app here

SemKl commented 10 months ago

This may be redundant and correlated to this issue, but adding to this I would love to have equal rights in collaborators for albums. I would like to have a few users to collaborate for an album, which can be shared to view-only users. Currently, an album is owned by its creator. Collaborators can add pictures and delete them, but they cannot delete the pictures the original creator added. They are also unable to delete albums not created by themselves. More roles for albums would be great.

komoricodrutz commented 10 months ago

This may be redundant and correlated to this issue, but adding to this I would love to have equal rights in collaborators for albums. I would like to have a few users to collaborate for an album, which can be shared to view-only users. Currently, an album is owned by its creator. Collaborators can add pictures and delete them, but they cannot delete the pictures the original creator added. They are also unable to delete albums not created by themselves. More roles for albums would be great.

Hi, I just tested this. Unfortunately it does not appear to be the case. I created a test album, added a picture to it and shared it with other users From those users' accounts I was able to delete the picture. So Collaborators are able to remove the pictures. Not delete the source picture itself, but remove it from the album. I didn't test the ability of removing the album altogether, nor did I test if they can delete the source picture. And I don't think it's related to the fact, that the picture I shared is located on an external storage. One of the users I tested this with does NOT have access to that external storage.

Memories 6.2.2 NC 27.1.5

SemKl commented 10 months ago

This may be redundant and correlated to this issue, but adding to this I would love to have equal rights in collaborators for albums. I would like to have a few users to collaborate for an album, which can be shared to view-only users. Currently, an album is owned by its creator. Collaborators can add pictures and delete them, but they cannot delete the pictures the original creator added. They are also unable to delete albums not created by themselves. More roles for albums would be great.

Hi, I just tested this. Unfortunately it does not appear to be the case. I created a test album, added a picture to it and shared it with other users From those users' accounts I was able to delete the picture. So Collaborators are able to remove the pictures. Not delete the source picture itself, but remove it from the album. I didn't test the ability of removing the album altogether, nor did I test if they can delete the source picture. And I don't think it's related to the fact, that the picture I shared is located on an external storage. One of the users I tested this with does NOT have access to that external storage.

Memories 6.2.2 NC 27.1.5

Huh. I’ve been unable to replicate it now (on my phone) as well. The behavior I described occurred on my laptop, but now I’m doubting myself, haha. I must be mistaken.

Still, it would be nice if albums are not required to have an owner. All albums will now say “shared by X” for everyone. Shared ownership like with group folders would be cool.

komoricodrutz commented 7 months ago

Memories 7.0.2 NC 27.1.7 Pretty please?!

florent4014 commented 2 months ago

It is the only reason why i'm sharing folders instead of albums because i can at least share them in read-only and not having others users deleting files. It would be really awesome to change that !

BHuck74 commented 1 week ago

Same here! I don’t understand why this feature wasn’t implemented from the start. 🤷‍♂️ I was considering shutting down my Piwigo instance, since I’m already running a Nextcloud instance in parallel. However, for now, I’m holding off on that because I’m unable to share read-only albums.