pulsejet / memories

Fast, modern and advanced photo management suite. Runs as a Nextcloud app.
https://memories.gallery
GNU Affero General Public License v3.0
3.17k stars 86 forks source link

Images are opened on mouse button press instead of release #641

Open epenttila opened 1 year ago

epenttila commented 1 year ago

Describe the bug I believe typical behavior is to perform actions when the mouse button is released. This is also how the default Photos app and Google Photos work.

To Reproduce Steps to reproduce the behavior:

  1. Open timeline view
  2. Press left mouse button on any image
  3. Image opens

Platform:

pulsejet commented 1 year ago

This was done on purpose. Is it creating any issues?

epenttila commented 1 year ago

I guess it's mostly just a UX issue as it makes the navigation feel a bit strange and unconventional. What was the reason to make it work the current way?

pulsejet commented 1 year ago

There was something else, but it makes opening the photos much quicker (perception of speed), e.g. comparing with Google Photos side-by-side.

MuQ-dev commented 1 year ago

Another thing to note is that images open when clicking the side mouse buttons of a mouse (forward and back) when hovering over an image. Not sure, whether that's intentional.

pulsejet commented 1 year ago

Another thing to note is that images open when clicking the side mouse buttons of a mouse (forward and back) when hovering over an image. Not sure, whether that's intentional.

Only left click will open the photo now.

epenttila commented 1 year ago

One inconsistency that came up is that the "x years ago" images at the top open on mouse button release.