pulsejet / memories

Fast, modern and advanced photo management suite. Runs as a Nextcloud app.
https://memories.gallery
GNU Affero General Public License v3.0
3.02k stars 80 forks source link

Android app: local files added to albums result in no-op #976

Open daniel-callejas-sevilla opened 7 months ago

daniel-callejas-sevilla commented 7 months ago

Describe the bug I can select pictures from a local folder on my phone, and then try to add them to an album.

Expected behavior: the pictures are queued in my phone, so that the app will add them to the selected album as soon as they become available in the Nextcloud Memories timeline (which can be minutes, hours, days, weeks or months afterwards).

Actual behaviour: the pictures are not added to any album, and the only indication that the action failed is "0 pictures updated" toast in the top-right corner.

To Reproduce Steps to reproduce the behavior:

Select a picture from a local folder, click on "..." → Add to album → select any album → "Save Changes."

Expected: picture is kept in waiting status until it is available as part of timeline, and then it gets added to album.

Actual: "0 photos updated"

Platform:

Additional context I should be able to sort my photos into albums without having to pause until the photos are synced. If this is not a goal of the Android app, then the app should actively prevent me from trying to add local photos to an album.

Drup commented 5 months ago

small bump, since it makes the app completely useless for me: I would really like to sort my local photos into saved albums. I'm actually not even sure what's the workaround (the "right" workflow is not obvious to me). Since you are pushing memories as a Google Photos alternative, I'm probably not the only one wanting this.

pulsejet commented 5 months ago

small bump, since it makes the app completely useless for me: I would really like to sort my local photos into saved albums.

That's unrelated to this issue. This issue is, you can "attempt" to add un-uploaded photos to album and nothing happens.

I'm actually not even sure what's the workaround (the "right" workflow is not obvious to me).

The right workflow is to auto upload files, always.

Since you are pushing memories as a Google Photos alternative, I'm probably not the only one wanting this.

I'm not sure of the use case here. If you add a local photo to an album, that photo was never uploaded and so it'll only ever be visible on that device. Does google photos let you do this?

daniel-callejas-sevilla commented 5 months ago

small bump, since it makes the app completely useless for me: I would really like to sort my local photos into saved albums.

That's unrelated to this issue. This issue is, you can "attempt" to add un-uploaded photos to album and nothing happens.

I'm actually not even sure what's the workaround (the "right" workflow is not obvious to me).

The right workflow is to auto upload files, always.

I have auto-upload for all my pictures, always. However, my phone does not always have network connectivity for a long period (e.g. a trek in the mountains, a stay in a foreign country, or just simply that the auto-upload takes a long time because my network coverage is spotty).

The main point of this issue is to allow for pictures to be sorted into albums regardless of whether they are auto-uploaded or still pending to auto-upload.

Since you are pushing memories as a Google Photos alternative, I'm probably not the only one wanting this.

I'm not sure of the use case here. If you add a local photo to an album, that photo was never uploaded and so it'll only ever be visible on that device. Does google photos let you do this?

Yes. Sorting photos into albums is completely independent form having photos uploaded to server. And whenever data is synchronized between phone and server, both the pictures themselves, and the sorting of pictures into albums, get synchronized to server.

Drup commented 5 months ago

That's unrelated to this issue. This issue is, you can "attempt" to add un-uploaded photos to album and nothing happens.

The right workflow is to auto upload files, always.

That is exactly the point though: I don't want to auto-upload. I would like to sort first. I think it's a fairly reasonable workflow (and more parsimonious, bandwidth-wise). Google Photos supports that transparently.

pulsejet commented 5 months ago

Interesting. I'll just leave a note here then that this is a major undertaking and will likely not be fixed in the near term unless someone is willing to contribute the feature.

Basically albums are handled completely server side at the moment, and so there's no concept of a "local" album (or even a local photo in an album). Adding photos not uploaded yet to albums would also require a whole new level of background synchronization that simply doesn't exist yet.

Drup commented 4 months ago

In that case, in the meantime, I would propose the following changes:

Since the app shows me the local pictures (which I like), its UI should reflect what I can/can't do on them.