search

pulsejet / nextcloud-oidc-login

Nextcloud login via a single OpenID Connect 1.0 provider
https://apps.nextcloud.com/apps/oidc_login
GNU Affero General Public License v3.0
219 stars 59 forks source link

Use group ID and not display name on remove #238

Closed fcharlaix-opendsi closed 1 year ago

fcharlaix-opendsi commented 1 year ago

In the login service, group display name and ID are mixed, causing users to be removed and added to the same group when a display name is set.

This problem sends notifications to the user (if enabled) and remove external storage on the desktop client (if external storage are disabled when added, the default behavior in the desktop client configuration).

pulsejet commented 1 year ago

Hmm this isn't super intuitive since it makes impossible to rename groups. Perhaps it might make more sense to exclusively use the display name of the group over the GID

EDIT: the fundamental issue is that the GID isn't very obvious, e.g. in the admin panel unless you look at the URL

EDIT 2: on second thoughts, probably sticking to GID is the best and document this instead.

pulsejet commented 1 year ago

Pls ignore the false alarm. Should be good with https://github.com/pulsejet/nextcloud-oidc-login/commit/092c22383bc27beab5d0c6dce604fafa61b5b6c1