pulsejet / nextcloud-oidc-login

Nextcloud login via a single OpenID Connect 1.0 provider
https://apps.nextcloud.com/apps/oidc_login
GNU Affero General Public License v3.0
219 stars 59 forks source link

logout: make logout code more similar to upstream & fix logout redirects #245

Open haslersn opened 12 months ago

haslersn commented 12 months ago

See https://github.com/nextcloud/server/blob/b085803c0bfe8c568e5710525e49d5f6378833b6/core/Controller/LoginController.php#L99 and following lines.

Also note that setting clearingExecutionContexts is no longer required, because it had to do with the executionContexts feature which is no longer used by nextcloud since https://github.com/nextcloud/server/pull/16310. Furthermore, with the behavior introduced in https://github.com/nextcloud/server/pull/12573, setting clearingExecutionContexts breaks our logout redirects, because the middleware subsequently (after the logout redirect) returns another redirects to /login?clear=1.