pulsejet / nextcloud-oidc-login

Nextcloud login via a single OpenID Connect 1.0 provider
https://apps.nextcloud.com/apps/oidc_login
GNU Affero General Public License v3.0
219 stars 59 forks source link

handle POSTLogout issue to resolve deleting account on SSO #273

Closed theronakpatel closed 4 months ago

theronakpatel commented 5 months ago

Resolving: https://github.com/pulsejet/nextcloud-oidc-login/issues/272

NOTE: The issue comes only when using the delete functionality from the app drop_account.

Error message on UI when deleting account logged in using SSO at murena.io

  • The issue is PostLogin listener is redirecting the execution for API call. So that is why it returns Network error as I mentioned in the ticket. So to resolve this, we should not redirect when there is an API call.
theronakpatel commented 4 months ago

@pulsejet I tried this solution , but it does not work, so I reverted back.

ronakpp commented 4 months ago

@pulsejet Can you test at your side too if possible and approve if all looks good.

pulsejet commented 4 months ago

LGTM, thanks

ronakpp commented 4 months ago

@pulsejet What is the expected date of new release with this change?