search

pulseshift / openui5-gulp-starter-kit

A progressive enterprise-ready project template with Gulp and OpenUI5
MIT License
51 stars 12 forks source link

SAPUI5 and FLP #3

Open js1972 opened 7 years ago

js1972 commented 7 years ago

This looks Iike a great setup but I'm wondering how it will work for all of us that are building apps with SAPUI5. I understand we can edit the packag.json to point the build process to the SAPUI5 CDN (soon to be available as a download like openui5 as well); but What about building apps which are to run within the Fiori Launchpad? In the WebIDE for example a dummy launchpad is created which your app runs within? Would be very cool if the same could be done here - then we can smoothly move between this build tool for local development and the WebIDE.

fuchsvomwalde commented 7 years ago

Regarding Web IDE: We are currently not using Web IDE internally. Therefore this is not a priority for us. However, in the future it might be possible to reuse some modules in Web IDE via extensions. Any kind of contributions with regards to that matter are more than welcome. But it is well conceivable that we can add an open source alternative of the Fiori Launchpad in the future. We leave the issue open to continue discussions and to wait for the interest of the community on this issue.

nimble-123 commented 6 years ago

Is it possible to deploy the build app to a Netweaver ABAP Server? There is gulp-nwabap-ui5uploader to deploy to ABAP server, but your gulp config generates a folder with random name inside the /dist folder. I can not find the place where this has to be configured to be a static folder name.

Inside this random named folder the component.js is located, which act as the entry point if the app is launched through Fiori Launchpad hosted on SAP Gateway/Netweaver.

As i understand gulp-nwabap-ui5uploader docs, i need to declare the root path of the app. So i think a static folder name might fix this and we could use this starter-kit even to develop in SAP Netweaver environment.

Thought this is also SAPUI5 and FLP related so did not open a new issue :)

fuchsvomwalde commented 6 years ago

Hi nlsltz,

great point. I think gulp-nwabap-ui5uploader https://www.npmjs.com/package/gulp-nwabap-ui5uploader is interesting. So I created a new branch nwabap (https://github.com/pulseshift/openui5-gulp-starter-kit/tree/nwabap) with a veriosn of the starter kit that is using this gulp plugin to upload all apps to their respective BSP destination on a SAP NW at the end of the yarn build task.

The cache buster is deactivated for this scenario. If we find a way to deploay the index.html, too, to the BSP, it should be no problem to switch the cache buster on again.

Unfortunately without an ABAP system I was not able to test the new functionality, so we would be happy for any testing, feddback or even better: pull requests. :-)

Cheers

Am 04.10.2017 um 20:22 schrieb nlsltz notifications@github.com:

Is it possible to deploy the build app to a Netweaver ABAP Server? There is gulp-nwabap-ui5uploader https://www.npmjs.com/package/gulp-nwabap-ui5uploader to deploy to ABAP server, but your gulp config generates a folder with random name inside the /dist folder. I can not find the place where this has to be configured to be a static folder name.

Inside this random named folder the component.js is located, which act as the entry point if the app is launched through Fiori Launchpad hosted on SAP Gateway/Netweaver.

As i understand gulp-nwabap-ui5uploader https://www.npmjs.com/package/gulp-nwabap-ui5uploader docs, i need to declare the root path of the app. So i think a static folder name might fix this and we could use this starter-kit even to develop in SAP Netweaver environment.

Thought this is also SAPUI5 and FLP related so did not open a new issue :)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/pulseshift/openui5-gulp-starter-kit/issues/3#issuecomment-334245966, or mute the thread https://github.com/notifications/unsubscribe-auth/AITaU6WhWkbQhTcxhO1ntsayTbzZVpqdks5so8zdgaJpZM4OLxYa.

nimble-123 commented 6 years ago

@fuchsvomwalde this was blazing fast ^^ i do have access to an ABAP system tomorrow and will provide feedback as fast as i tried the new branch.

cheers 🖖

nimble-123 commented 6 years ago

Tried the deployment and got this error.

[09:06:26] Error in plugin 'gulp-nwabap-ui5uploader' Message: Source contains paths outside of root

I think it has something to do with references of some libs in the build app? Maybe you have some hints :)

EDIT: yep, found the corresponding line in gulp-nwabap-ui5uploader. now we have to figure out which source file contains a reference to outside of root folder and get rid of this ^^

EDIT2: temporarly disabled the exception but now gulp quircks around with this error [09:55:42] [OK] BSP-Container ZZ_UI5_LOCAL created. [09:55:42] The following tasks did not complete: ui5Upload [09:55:42] Did you forget to signal async completion?

might missing some config for async completion or has to do with promises.