search

pulumi / ci-mgmt

Configuration for all things CI
Apache License 2.0
11 stars 4 forks source link

Ability to disable publishing to the Pulumi CDN #1077

Closed ringods closed 2 months ago

ringods commented 2 months ago

Ability to disable publishing to the Pulumi CDN (get.pulumi.com) for non-Pulumi managed providers.

Ran make test-providers which didn't render any changes, but it worked for my pulumiverse/pulumi-acme provider.

guineveresaenger commented 2 months ago

I apologize for the question, but what is Pulumi CDN?

This looks reasonable to me otherwise - I would like to see a third-party provider test in the repo maybe, so we can see the applied changes alongside the PR.

ringods commented 2 months ago

@guineveresaenger I updated the initial comment. Pulumi CDN is get.pulumi.com which is not accessible for 3rd party packages.

This commit uses this setting for the Pulumiverse ACME provider. Besides setting the property, it is a no-op because I had removed these steps manually from the setup before.

https://github.com/pulumiverse/pulumi-acme/commit/687dedc915e6eb97859d3dc4e8bfe6a13bc21284

Should I mimic the acme setup under the make test-providers build target?

ringods commented 2 months ago

@guineveresaenger acme added as test provider.