pulumi / ci-mgmt

Configuration for all things CI
Apache License 2.0
11 stars 4 forks source link

AttributeError: module 'pulumi.runtime' has no attribute 'invoke_output' #1091

Closed t0yv0 closed 1 month ago

t0yv0 commented 1 month ago

Remediate "AttributeError: module 'pulumi.runtime' has no attribute 'invoke_output'".

From @justinvp:

These are the relevant changes and releases: https://github.com/pulumi/pulumi/pull/17237 - Core SDK and sdkgen change for Node.js (released in v3.133.0) https://github.com/pulumi/pulumi/pull/17275 - Core SDK and sdkgen change for Python (released in v3.134.0) https://github.com/pulumi/pulumi/pull/17316 - Bump Node.js sdkgen’s min version to v3.133.0 (released in v3.134.0) https://github.com/pulumi/pulumi/pull/17353 - Fix bug in Node.js Core SDK (short-circuit output invokes if inputs contains unknowns) (released in v3.134.1) https://github.com/pulumi/pulumi/pull/17390 - Bump Node.js and Python sdkgen’s min version to v3.134.1 (released in v3.135.0)

Summary: v3.133.0 sdkgen is problematic for Node.js. It needs v3.135.0 sdkgen and to not be setting the explicit @pulumi/pulumi dependency so that sdkgen emits the default min version. v3.134.0 sdkgen is problematic for Python. It needs v3.135.0 sdkgen and to not be setting the explicit pulumi dependency so that sdkgen emits the default min version.

To remediate we need to make sure to remove explicit p/p dependency, for example:

Also please remove it for .NET

Native Providers

Bridged Providers

Tier 1

Tier 2

t0yv0 commented 1 month ago

@pulumi/providers

I'll have a quick look at AWS ones, and tier 1.

t0yv0 commented 1 month ago

Per @danielrbradley there are some uncertainties whether the .NET change is wanted or not so we're scoping that out and leaving as-is for now.

t0yv0 commented 1 month ago

I'm at EOD status so far:

Will work with @flostadler to cover AWS Tier-2+ things tomorrow.

For the long tail of bridged providers I think we can script this as they're pretty uniform.

Will need to load-balance and assign remaining native ones @mjeffryes

flostadler commented 1 month ago

Checking in here. I'm working my way through the AWS providers now

VenelinMartinov commented 1 month ago

https://github.com/pulumi/ci-mgmt/pull/1092 should address this for all the lower tier providers

flostadler commented 1 month ago

I created PRs for AWS Tier-2+ providers and added them to the list above. For EKS I've targeted it for EKS v3 because the current v2 is not affected (uses v3.129.0 for generating the schema).

t0yv0 commented 1 month ago

Thanks all, very fast work here!

Stood up 3 more PRs for native providers, PTAL.

google-native won't fix I think.

Need review on those 3 PRs and still need help on azure-native, once that's in we can close I think.

pulumi-bot commented 1 month ago

Cannot close issue:

Please fix these problems and try again.