Upgrade workflows create duplicate issues and pull requests

pulumi / ci-mgmt

Configuration for all things CI

Apache License 2.0

10 stars 4 forks source link

Upgrade workflows create duplicate issues and pull requests #1125

Open guineveresaenger opened 6 hours ago

guineveresaenger commented 6 hours ago

https://github.com/pulumi/ci-mgmt/pull/1110 seems to have caused an identical issue to be created every time the upgrade workflow runs. When all of the automation succeeds without intervention, this is not a problem. But in cases where the upgrade needs manual assistance, we'll see the same issue created over and over:

If an issue already exists, we should not create another one.

Additionally, if an automated pull request is not merged same-day, an (identical, most likely) new one is opened:

guineveresaenger commented 6 hours ago

More information:

https://github.com/pulumi/pulumi-artifactory/issues/929 was not discovered or closed by https://github.com/pulumi/pulumi-artifactory/pull/930 - these were likely created in the same workflow and the PR should have closed the issue (but maybe the existence of older issues confused thigs?)
Additionally, the duplicative pull requests did not auto-close when https://github.com/pulumi/pulumi-artifactory/pull/930 merged.

guineveresaenger commented 6 hours ago

https://github.com/pulumi/pulumi-alicloud/pull/829 on the other hand, closes all 3 identically-named issues.

The main fix here seems to be to not open duplicative issues or pull requests.