pulumi / circleci

CircleCI Orbs for CI/CD using Pulumi.
Apache License 2.0
20 stars 15 forks source link

Add stack init/rm orb #14

Closed kenfdev closed 4 years ago

kenfdev commented 4 years ago

Add the pulumi stack init and pulumi stack rm command to the orb.

Closes #10

Let me add some comments for advice.

kenfdev commented 4 years ago

Thank you for your extremely detailed review @chrsmith ! I perfectly understand the required changes. If my final change is valid, I'll squash the commits and make this an official PR.

Let me work on the other two issues as well. I should be able to do it :)

kenfdev commented 4 years ago

Use a (not yet added, could you add it to this PR if it isn't too much trouble?) pulumi stack output command

Oh wait, should I add this change to this PR? I was thinking about creating another PR with #15 #16 .

kenfdev commented 4 years ago

@chrsmith Thank you for the review! This PR should be ready to be merged 👍