Closed kenfdev closed 4 years ago
Some simple fixes to apply the best practices. I was a bit skeptic about the version written in x.y but looking at the slack orb, it actually means to write as x.y. Hence I changed it.
x.y
https://github.com/CircleCI-Public/slack-orb/blob/staging/src/examples/approval.yml#L7
Also added a description of the access token.
Related issue: #8
I'll squash the commits if appropriate ;)
cc @chrsmith
Some simple fixes to apply the best practices. I was a bit skeptic about the version written in
x.y
but looking at the slack orb, it actually means to write asx.y
. Hence I changed it.https://github.com/CircleCI-Public/slack-orb/blob/staging/src/examples/approval.yml#L7
Also added a description of the access token.
Related issue: #8