search

pulumi / circleci

CircleCI Orbs for CI/CD using Pulumi.
Apache License 2.0
20 stars 15 forks source link

Creating an EKS cluster Failed to create with current Orb #7

Closed roachmd closed 5 years ago

roachmd commented 5 years ago

When creating and EKS cluster in AWS, I found additional items had to be installed. I've submitted #6 to resolve this issue.

roachmd commented 5 years ago

We probably need Orbs specific for each provider AWS, GCLOUD, ETC....

chrsmith commented 5 years ago

Thanks for filing an issue and submitting a PR @roachmd. Though like you mentioned in the PR, it's probably too specific/opinionated. For example, it's just wasted cycles if you aren't using those cloud providers, or even if you are, you might want to use a different toolchain.

I'm inclined to think that this sort of thing -- including the dependencies for your Pulumi project -- probably doesn't belong in the Pulumi orb itself, and certainly not the login step. But I can definitely see the need for a general purpose orb for downloading/installing common 3rd party libraries and tools. e.g. a install-gcloud or install-kubectl command.

But even then it might make sense to put in the Pulumi orb, as Pulumi itself is a general tool that doesn't try to inject opinions about how you should be going about building or managing resources.

I'll close this issue out as "working as intended", but if you have suggestions for how we can better document how to setup an EKS cluster on CircleCI and Pulumi please do let me know.

For example, it looks like we can just add those steps from your PR in a new "example" within the orbs file? e.g. https://github.com/pulumi/circleci/blob/master/orbs/pulumi.yml#L108? That would be super-useful for other developers.

w2g-roachmd commented 5 years ago

You can use my PR steps as a new example or I can pr one for you.

I've decided to build our own orb from this example.