Open biasedbit opened 1 year ago
Hi @biasedbit !!! I tried the instructions that you detailed and yes, it does work indeed. I also checked: https://minikube.sigs.k8s.io/docs/handbook/accessing/#loadbalancer-access.
However, the changes that I noticed in the step was that minikube tunnel
does not prompt for any password. And curl "http://localhost:8080" does not work unless it is port forwarded.
pulumiminikube.txt
kubernetesservices.txt
testingthepulumistack.txt
A better approach to documentation update would be to remove the condition service logic isMinikube
in all the code examples and mention about using minikube tunnel
.
Also:
I noticed something else too. In the getting started there are no instructions to deploy an app. We are only providing instructions to check if the service is deployed and if we used YAML the isMinikube config need not be set. The deployment goes through. Here's the terminal output of the same.
yamltestwithoutisMinikube.txt
@ringods and @desteves please let me know your thought on this approach to documentation and I am more than happy to submit a PR with the changes.
Just submitted a PR with changes for Python and YAML https://github.com/pulumi/pulumi-hugo/pull/3521
Checking in here: @desteves (https://github.com/pulumi/pulumi-hugo/pull/3841) and @Rajakavitha1 (https://github.com/pulumi/pulumi-hugo/pull/3521) both had submitted PRs that would address this issue, however they were never merged, and the repo the PRs were on is now archived (pulumi-hugo
). It seems like @desteves PR would supersede the previous one by @Rajakavitha1, though both are still "open".
@interurban We migrated the issues from that repo, but it seems the open PRs didn't migrate? This feels like a loss of good work. Should we move https://github.com/pulumi/pulumi-hugo/pull/3841 here and get it merged? Or are do we prefer to abandon these PRs and keep the example as-is? If so, we should probably close this ticket as wont-fix
.
The Pulumi & Kubernetes guide can be updated to remove the conditional service logic for minikube. I got through the example using minikube with
isMinikube
set tofalse
.Steps to reproduce:
In a separate terminal, run
minikube tunnel
(required forLoadBalancer
to obtain IP127.0.0.1
)Follow all instructions with
isMinikube
set tofalse
Modify
frontend
service external port to 8080:Run
pulumi up
Use
curl
to validate setup:Notes:
minikube tunnel
minikube tunnel
must be running, otherwise service creation will stall waiting for IP assignmentEnv details