search

pulumi / docs

All things Pulumi docs!
https://pulumi.com
Apache License 2.0
129 stars 222 forks source link

Closing and reopening a PR probably causes a failure #11632

Open jkodroff opened 1 year ago

jkodroff commented 1 year ago

We're in the middle of a blog post release, so I can't provide full details/debugging, but it looks like closing an reopening a PR causes a failure in the build actions. The issue seems to persist if I create s new PR from the same branch:

make_bucket: pulumi-hugo-origin-pr-2668-a0af4c46
Synchronizing to s3://pulumi-hugo-origin-pr-2668-a0af4c46...
Sync complete.
http://pulumi-hugo-origin-pr-2668-a0af4c46.s3-website.us-west-2.amazonaws.com/
Completed 6 Bytes/6 Bytes (37 Bytes/s) with 1 file(s) remaining
upload: public/latest-version to s3://pulumi-hugo-origin-pr-2668-a0af4c46/latest-version
Writing result metadata.
Completed 237 Bytes/237 Bytes (1.3 KiB/s) with 1 file(s) remaining
upload: ./origin-bucket-metadata.json to s3://pulumi-hugo-origin-pr-2668-a0af4c46/metadata.json

An error occurred (ParameterAlreadyExists) when calling the PutParameter operation: The parameter already exists. To overwrite this value, set the overwrite option in the request to true.
make: *** [Makefile:46: ci-pull-request] Error 254
Error: Process completed with exit code 2.

https://github.com/pulumi/pulumi-hugo/actions/runs/4641506644/jobs/8214550437?pr=2668

sean1588 commented 1 year ago

@jkodroff yeah I believe this is due to reopening the PR that was previously closed. I believe it is due to a collision in the parameter store, since the keys are derived from the commit sha if I am remembering correctly. So when you reopened, it was probably at the same commit that it was at before and tried to put the same parameter that was already existing when it attempted to regen the preview. We should be able to find a way around this.

susanev commented 1 year ago

@sean1588 would this be a good thing to add to the papercuts tracking issue?