Improve mobile performance

pulumi / docs

All things Pulumi docs!

https://pulumi.com

Apache License 2.0

127 stars 222 forks source link

Improve mobile performance #11789

Open joeduffy opened 4 years ago

joeduffy commented 4 years ago

I didn't seen an issue already tracking this, so filing to make sure we don't lose track. We currently have relatively poor performance on mobile, as scored by Google:

This is hurting our SEO and ads performance.

Some specific ideas from @zchase to help move the needle here are:

Lazy load images
Take advantage of hugo's image resize api to properly size images when served on mobile
Figure out what to do with the unused css issue. We use tailwindcss library and I am assuming we have to load the entire library on each page

I'm assigning to both @cnunciato and @zchase since I'm unsure who technically owns this.

zchase commented 4 years ago

Ran some speed experiments today and here are the results:

Based on those results and I think the simplest path forward is lazy loading and using PurgeCSS to reduce our CSS bundle size. Though happy to hear other suggestions as well

cnunciato commented 4 years ago

Also note HTML minification was just merged (with https://github.com/pulumi/docs/pull/2456), which reduces page sizes by ~20%.

zchase commented 4 years ago

PurgeCSS work has landed (https://github.com/pulumi/docs/pull/2444). We saw a small increase in page speed but not the same increase as I was seeing locally. I will re-run the page speed test tomorrow AM and update the issue with the new metrics.

zchase commented 4 years ago

Updated page speed score after @cnunciato & my changes. Progress 💪

lukehoban commented 3 years ago

FWIW - this appears to have gone back down again.

susanev commented 2 years ago

slightly up again

susanev commented 2 years ago

@kimberleyamackenzie would you have interest in investigating performance on mobile?

kimberleyamackenzie commented 2 years ago

@susanev yes, for sure!

susanev commented 2 years ago

@cnunciato @zchase i dropped yalls assignments, but if either of you start actively working on this before the user experience team picks it up pls reassign yourselves!

cnunciato commented 2 years ago

Thanks much. @kimberleyamackenzie note that we run Lighthouse on the website once a day as well (https://github.com/pulumi/docs/actions/workflows/check-lighthouse.yml), and we store the results of previous runs as GHA artifacts, so you should be able to see how things have changed at various URLs over time.