search

pulumi / docs

All things Pulumi docs!
https://pulumi.com
Apache License 2.0
127 stars 221 forks source link

Fix PR closed job #12885

Closed sean1588 closed 1 week ago

sean1588 commented 1 week ago

I had reverted this original PR since it had an error because we needed to specify the github environment. This is now resolved here.

Our PR closed jobs have not been cleaning up and of the buckets associated with their PRs and have been failing silently since it thinks there were no buckets to delete.

I made some adjustments to the job to fix this as well as remove the dependency we had on the SSM parameter store. We used to use the store to persist each commit for a PR and then find buckets based on that. I have simplified this a bit to remove this dependency altogether as it doesn't look like this complexity is needed and instead just remove all buckets via <origin_bucket_prefits>-pr-<pr-number>, since we do want to delete all buckets associated with that PR anyway.

pulumi-bot commented 1 week ago

Your site preview for commit 0acf2b97 is ready! :tada:

http://www-testing-pulumi-docs-origin-pr-12885-0acf2b97.s3-website.us-west-2.amazonaws.com.

pulumi-bot commented 1 week ago

Your site preview for commit 2d86edef is ready! :tada:

http://www-testing-pulumi-docs-origin-pr-12885-2d86edef.s3-website.us-west-2.amazonaws.com.

pulumi-bot commented 1 week ago

Your site preview for commit 9519257e is ready! :tada:

http://www-testing-pulumi-docs-origin-pr-12885-9519257e.s3-website.us-west-2.amazonaws.com.