pulumi / docs

All things Pulumi docs!
https://pulumi.com
Apache License 2.0
127 stars 222 forks source link

Add parent branding to practitioner navigation #8966

Open anita-trimbur opened 1 year ago

anita-trimbur commented 1 year ago

Overview

We're introducing sub-branding elements to the practitioner navigation (topmost black bar) in Docs & Registry. This parent "Documentation" branding will be a parent to all sub-categories of documentation in an effort to unify these experiences.

Design file

Figma preview

practitioner-nav-branding (2)

Changes

Style changes

susanev commented 1 year ago

@anita-trimbur can you update this issue since this has changed a bit?

susanev commented 1 year ago

@anita-trimbur ive been putting this off because i still don't feel good about calling the parent Documentation since the label in the marketing nav and practitioner nav is Docs. i think we have two options..

  1. go with Docs branding, even though its weird since part of docs is docs
  2. do no branding at all

my preference is 1 because i really think it ties it together. but what do you think? and are there any additional options we should consider?

anita-trimbur commented 1 year ago

did we ever hear back from marketing if they had an opinion on the naming convention here? i do think docs in docs is strange, but i agree with you that have some label is going to make this structure feel a lot more straightforward. would we be adding this parent name to the breadcrumb? unless we went back to using the <> icon from the designs, that would give us a structure of Docs / Docs / .... but if we can circumvent that, i support option 1.

susanev commented 1 year ago

@anita-trimbur this change wont affect any breadcrumbs, it will only b e adding the badge to the top bar; i think we should wait to add <> until the bigger decision is made. ill open a pr and me you and Sean can figure out if we want to do it from there.

i haven't heard anything from marketing. 🤷🏻