pulumi / examples

Infrastructure, containers, and serverless apps to AWS, Azure, GCP, and Kubernetes... all deployed with Pulumi
https://www.pulumi.com
Apache License 2.0
2.36k stars 877 forks source link

Fix aws-ts-static-website bucket reference #1390

Closed cnunciato closed 1 year ago

cnunciato commented 1 year ago

Fixes #1347. Fixes https://github.com/pulumi/examples/issues/1391.

This change also adds a handful of test-related fixes to get this PR's tests to pass and to clear the way for others going forward. (PR tests had been passing, but apparently began failing again last week.) The gist is that because many of our integration tests seem to produce diffs unexpectedly, we've historically sprinkled lots of exceptions throughout the code to ignore these diffs in order to make the tests pass. I've been propagating this pattern for a little while myself, but I'd rather not do that anymore. Instead, considering this repo is not (or is no longer) concerned with low-level provider behavior like this, and since we don't seem to have done anything to address these issues up to now (other than just adding more exceptions), I've chosen to apply these exceptions to all tests, across the board.

pulumi-staging[bot] commented 1 year ago

:tropical_drink: The Update for moolumi/k8s-ci-cluster/cb32be60cb4ba67f106ddcc6f9c178c032167ce4-938 was successful.

Resource Changes

    Name                                                         Type                                        Operation
+   multicloud                                                   pulumi-kubernetes:ci:GkeCluster             create
+   password                                                     random:index/randomPassword:RandomPassword  create
+   ephemeral-ci-cluster                                         gcp:container/cluster:Cluster               create
+   primary-node-pool                                            gcp:container/nodePool:NodePool             create
+   gke                                                          pulumi:providers:kubernetes                 create
+   k8s-ci-cluster-cb32be60cb4ba67f106ddcc6f9c178c032167ce4-938  pulumi:pulumi:Stack                         create
pulumi-staging[bot] commented 1 year ago

:tropical_drink: The Update for moolumi/k8s-ci-cluster/e98481416d6be4d1555f3434bdb4f0b41808ca90-939 was successful.

Resource Changes

    Name                                                         Type                                        Operation
+   multicloud                                                   pulumi-kubernetes:ci:GkeCluster             create
+   password                                                     random:index/randomPassword:RandomPassword  create
+   ephemeral-ci-cluster                                         gcp:container/cluster:Cluster               create
+   primary-node-pool                                            gcp:container/nodePool:NodePool             create
+   gke                                                          pulumi:providers:kubernetes                 create
+   k8s-ci-cluster-e98481416d6be4d1555f3434bdb4f0b41808ca90-939  pulumi:pulumi:Stack                         create
pulumi-staging[bot] commented 1 year ago

:tropical_drink: The Destroy for moolumi/k8s-ci-cluster/cb32be60cb4ba67f106ddcc6f9c178c032167ce4-938 was successful.

Resource Changes

    Name                  Type                                        Operation
-   ephemeral-ci-cluster  gcp:container/cluster:Cluster               delete
-   password              random:index/randomPassword:RandomPassword  delete
-   gke                   pulumi:providers:kubernetes                 delete
-   primary-node-pool     gcp:container/nodePool:NodePool             delete
pulumi-staging[bot] commented 1 year ago

:tropical_drink: The Update for moolumi/k8s-ci-cluster/a15825154a7bcf86d283bbcaa82250e5c936693b-940 was successful.

Resource Changes

    Name                                                         Type                                        Operation
+   multicloud                                                   pulumi-kubernetes:ci:GkeCluster             create
+   password                                                     random:index/randomPassword:RandomPassword  create
+   ephemeral-ci-cluster                                         gcp:container/cluster:Cluster               create
+   primary-node-pool                                            gcp:container/nodePool:NodePool             create
+   gke                                                          pulumi:providers:kubernetes                 create
+   k8s-ci-cluster-a15825154a7bcf86d283bbcaa82250e5c936693b-940  pulumi:pulumi:Stack                         create
pulumi-staging[bot] commented 1 year ago

:tropical_drink: The Destroy for moolumi/k8s-ci-cluster/e98481416d6be4d1555f3434bdb4f0b41808ca90-939 was successful.

Resource Changes

    Name                  Type                                        Operation
-   password              random:index/randomPassword:RandomPassword  delete
-   gke                   pulumi:providers:kubernetes                 delete
-   primary-node-pool     gcp:container/nodePool:NodePool             delete
-   ephemeral-ci-cluster  gcp:container/cluster:Cluster               delete
pulumi-staging[bot] commented 1 year ago

:tropical_drink: The Destroy for moolumi/k8s-ci-cluster/a15825154a7bcf86d283bbcaa82250e5c936693b-940 was successful.

Resource Changes

    Name                  Type                                        Operation
-   gke                   pulumi:providers:kubernetes                 delete
-   primary-node-pool     gcp:container/nodePool:NodePool             delete
-   ephemeral-ci-cluster  gcp:container/cluster:Cluster               delete
-   password              random:index/randomPassword:RandomPassword  delete
pulumi-staging[bot] commented 1 year ago

:tropical_drink: The Update for moolumi/k8s-ci-cluster/784a188cfd7c7a49e9c185ea9aef24e8e7c2da9e-941 was successful.

Resource Changes

    Name                                                         Type                                        Operation
+   primary-node-pool                                            gcp:container/nodePool:NodePool             create
+   gke                                                          pulumi:providers:kubernetes                 create
+   k8s-ci-cluster-784a188cfd7c7a49e9c185ea9aef24e8e7c2da9e-941  pulumi:pulumi:Stack                         create
+   multicloud                                                   pulumi-kubernetes:ci:GkeCluster             create
+   password                                                     random:index/randomPassword:RandomPassword  create
+   ephemeral-ci-cluster                                         gcp:container/cluster:Cluster               create
pulumi-staging[bot] commented 1 year ago

:tropical_drink: The Update for moolumi/k8s-ci-cluster/c0a6909bf4b174e7bcdeedb92cd611404f90a491-946 was successful.

Resource Changes

    Name                                                         Type                                        Operation
+   multicloud                                                   pulumi-kubernetes:ci:GkeCluster             create
+   password                                                     random:index/randomPassword:RandomPassword  create
+   ephemeral-ci-cluster                                         gcp:container/cluster:Cluster               create
+   primary-node-pool                                            gcp:container/nodePool:NodePool             create
+   gke                                                          pulumi:providers:kubernetes                 create
+   k8s-ci-cluster-c0a6909bf4b174e7bcdeedb92cd611404f90a491-946  pulumi:pulumi:Stack                         create
pulumi-staging[bot] commented 1 year ago

:tropical_drink: The Update for moolumi/k8s-ci-cluster/21009fd9c97042e981aecf3ace8948b147c0ce63-948 was successful.

Resource Changes

    Name                                                         Type                                        Operation
+   multicloud                                                   pulumi-kubernetes:ci:GkeCluster             create
+   password                                                     random:index/randomPassword:RandomPassword  create
+   ephemeral-ci-cluster                                         gcp:container/cluster:Cluster               create
+   primary-node-pool                                            gcp:container/nodePool:NodePool             create
+   gke                                                          pulumi:providers:kubernetes                 create
+   k8s-ci-cluster-21009fd9c97042e981aecf3ace8948b147c0ce63-948  pulumi:pulumi:Stack                         create
pulumi-staging[bot] commented 1 year ago

:tropical_drink: The Destroy for moolumi/k8s-ci-cluster/c0a6909bf4b174e7bcdeedb92cd611404f90a491-946 was successful.

Resource Changes

    Name                  Type                                        Operation
-   gke                   pulumi:providers:kubernetes                 delete
-   primary-node-pool     gcp:container/nodePool:NodePool             delete
-   ephemeral-ci-cluster  gcp:container/cluster:Cluster               delete
-   password              random:index/randomPassword:RandomPassword  delete
pulumi-staging[bot] commented 1 year ago

:tropical_drink: The Destroy for moolumi/k8s-ci-cluster/21009fd9c97042e981aecf3ace8948b147c0ce63-948 was successful.

Resource Changes

    Name                  Type                                        Operation
-   gke                   pulumi:providers:kubernetes                 delete
-   primary-node-pool     gcp:container/nodePool:NodePool             delete
-   ephemeral-ci-cluster  gcp:container/cluster:Cluster               delete
-   password              random:index/randomPassword:RandomPassword  delete
scottslowe commented 1 year ago

@cnunciato Is this PR ready for review?

cnunciato commented 1 year ago

@scottslowe Yep! Ready to go.