pulumi / examples

Infrastructure, containers, and serverless apps to AWS, Azure, GCP, and Kubernetes... all deployed with Pulumi
https://www.pulumi.com
Apache License 2.0
2.33k stars 874 forks source link

Update Azure Native examples to v2.1.1 #1467

Closed mnlumi closed 11 months ago

mnlumi commented 12 months ago

@cnunciato Would you be able review these updates? I've taken in the latest fixes for tests, there are still a few failing.

lukehoban commented 12 months ago

I believe there are two issues across the failing examples:

azure-native:insights:Component (ai): error: autorest/azure: Service returned an error. Status=400 Code="BadRequest" Message="Cannot set LogAnalytics as IngestionMode on current api-version" InnerError={"trace":["System.ArgumentException"]}

Sounds like a legitimate issue that needs to be fixed.

azure:lb:Rule (lbnatrule-http): error: deleting urn:pulumi:p-it-fv-az1230--classic-az-c4ac5288::azure-ts-vm-scaleset::azure:lb/rule:Rule::lbnatrule-http: 1 error occurred:

  • waiting for completion of Load Balancer "lba38cbe08" (Resource Group "vmss-rg5eeda2c8"): Code="NotFound" Message="Resource /subscriptions/***/resourceGroups//providers/Microsoft.Compute/tenants/38DF66CC-83A1-4EDF-A462-24DA3E8114E1 not found." Details=[]

Less clear what is happening here. Are you able to reproduce this issue locally in the TestAccAzureTsVmScaleset example?

scottslowe commented 12 months ago

WRT to the first failure @lukehoban identified (the error with azure-native:insights:Component, it looks like we just need to specify the ingestion mode. Unfortunately, the API reference page (https://www.pulumi.com/registry/packages/azure-native/api-docs/insights/component/) doesn't provide any details on ingestion mode (that supporting type is blank/missing details).

mnlumi commented 11 months ago

Opened https://github.com/pulumi/registry/issues/2966 for the api-docs.

mnlumi commented 11 months ago

@cnunciato @scottslowe All of the tests are passing 🎉

mnlumi commented 11 months ago

Resolves https://github.com/pulumi/examples/issues/1437