pulumi / examples

Infrastructure, containers, and serverless apps to AWS, Azure, GCP, and Kubernetes... all deployed with Pulumi
https://www.pulumi.com
Apache License 2.0
2.33k stars 874 forks source link

Fix aws-ts-containers compilation #1489

Closed t0yv0 closed 11 months ago

t0yv0 commented 11 months ago

It appears that "name" property is required. This currently causes CI failure to compile typescript for this example.

https://github.com/pulumi/pulumi-awsx/blob/master/awsx/schema.json#L1208 is the reference.

https://github.com/pulumi/pulumi-awsx/pull/1069 is the change that made this required.

CC @rquitales @mjeffryes

pulumi-staging[bot] commented 11 months ago

:tropical_drink: The Update for moolumi/k8s-ci-cluster/3fc32749bdfe4a041bab3d0f7cb9ab18cd20c61a-1504 was successful.

Resource Changes

    Name                                                          Type                                        Operation
+   multicloud                                                    pulumi-kubernetes:ci:GkeCluster             create
+   password                                                      random:index/randomPassword:RandomPassword  create
+   ephemeral-ci-cluster                                          gcp:container/cluster:Cluster               create
+   primary-node-pool                                             gcp:container/nodePool:NodePool             create
+   gke                                                           pulumi:providers:kubernetes                 create
+   k8s-ci-cluster-3fc32749bdfe4a041bab3d0f7cb9ab18cd20c61a-1504  pulumi:pulumi:Stack                         create
mjeffryes commented 11 months ago

We've broken examples a few times recently when updating providers; We should probably be building examples when making providers releases? Alternatively, should the examples versions be pinned somehow and updated after the release goes out?

pulumi-staging[bot] commented 11 months ago

:tropical_drink: The Destroy for moolumi/k8s-ci-cluster/3fc32749bdfe4a041bab3d0f7cb9ab18cd20c61a-1504 was successful.

Resource Changes

    Name                  Type                                        Operation
-   gke                   pulumi:providers:kubernetes                 delete
-   primary-node-pool     gcp:container/nodePool:NodePool             delete
-   ephemeral-ci-cluster  gcp:container/cluster:Cluster               delete
-   password              random:index/randomPassword:RandomPassword  delete
t0yv0 commented 11 months ago

We should probably be building examples when making providers releases

Well it's a possibility; it's going to be a draw on compute time but can help maintain this repo for sure.

The check failures are present on master independently yes.