pulumi / pulumi-aws-native

AWS Native Provider for Pulumi
Apache License 2.0
90 stars 17 forks source link

SQS Queue Redrive Policy typing #1329

Open kg-jcaron opened 5 months ago

kg-jcaron commented 5 months ago

Hello!

Issue details

The SQS redrivePolicy is not strictly typed (uses any in typescript, object in dotnet). Everything seems to work correctly with it, but it would be nice to have strict typing for the property names (deadLetterTargetArn and maxReceiveCount) like in the aws classic provider if possible.

mjeffryes commented 5 months ago

Thanks for pointing this out @kg-jcaron it should be possible to generate more useful types here.

danielrbradley commented 4 months ago

This appears to be an issue with the upstream specifications.

The type of this field is currently specified as: https://github.com/pulumi/pulumi-aws-native/blob/550eb8c0c6559a06d584fc996e2ab58f7af97d69/aws-cloudformation-schema/aws-sqs-queue.json#L83-L86

However in the CloudFormation documentation it more accurately describes the type as having two fields:

{ "deadLetterTargetArn" : String, "maxReceiveCount" : Integer }

This also applies to RedriveAllowPolicy.

mikhailshilkov commented 4 months ago

@danielrbradley Have you reported this in https://github.com/aws-cloudformation/cloudformation-coverage-roadmap/? (that's the upstream repo we should report CF issues to)

danielrbradley commented 3 months ago

No, I've not written this up as an issue for them yet. For some providers there's also separate repositories in https://github.com/aws-cloudformation/ for their specific implementations which are worth checking too for issues.

mikhailshilkov commented 3 months ago

Let's report the upstream issue as the first step

danielrbradley commented 3 months ago

Reported: https://github.com/aws-cloudformation/cloudformation-coverage-roadmap/issues/2012