pulumi / pulumi-aws-native

AWS Native Provider for Pulumi
Apache License 2.0
90 stars 17 forks source link

Fix truncated descriptions in docs #1572

Closed flostadler closed 3 weeks ago

flostadler commented 4 weeks ago

The documentation of some resources/properties is incomplete or incorrect in the AWS CloudFormation schema. The CloudFormation docs are more complete and accurate in these cases. This change adds the ability to choose for which resources the CloudFormation docs should be preferred.

It enrolls the following resources/properties in the CloudFormation docs:

We cannot automatically match which descriptions should get replaced by the CloudFormation docs because the two have subtle differences (extra/different punctuation marks, CFN vs AWS CloudFormation, etc.)

Fixes #1371 Fixes #1550

github-actions[bot] commented 4 weeks ago

Does the PR have any schema changes?

Looking good! No breaking changes found. No new resources/functions.

codecov[bot] commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 41.98%. Comparing base (baa54f8) to head (e9bc52a).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1572 +/- ## ========================================== + Coverage 41.67% 41.98% +0.31% ========================================== Files 35 35 Lines 4689 4702 +13 ========================================== + Hits 1954 1974 +20 + Misses 2533 2529 -4 + Partials 202 199 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

t0yv0 commented 3 weeks ago

🚢