search

pulumi / pulumi-aws-native

AWS Native Provider for Pulumi
Apache License 2.0
95 stars 17 forks source link

Nightly SDK regeneration #1675

Closed flostadler closed 3 months ago

flostadler commented 3 months ago

The SDK had to be manually regenerated because an empty string was added to the CFN schema of the `AWS::IVS::Channel.Preset" enum:

"Preset" : {
      "description" : "Optional transcode preset for the channel. This is selectable only for ADVANCED_HD and ADVANCED_SD channel types. For those channel types, the default preset is HIGHER_BANDWIDTH_DELIVERY. For other channel types (BASIC and STANDARD), preset is the empty string (\"\").",
      "type" : "string",
      "enum" : [ "", "HIGHER_BANDWIDTH_DELIVERY", "CONSTRAINED_BANDWIDTH_DELIVERY" ]
    }

The CloudFormation docs and AWS CLI docs mention that the allowed values are HIGHER_BANDWIDTH_DELIVERY, CONSTRAINED_BANDWIDTH_DELIVERY. But the empty string is also allowed and it's the default the IVS service sets internally (and returns) when a channel type is used that doesn't allow configuring a preset.

This change adds a special condition to the schema generator to create an enum value called Empty with an underlying value of "". We cannot omit this empty enum value as this would break SDKs that verify whether an enum value is valid (e.g. python).

Fixes #1674

github-actions[bot] commented 3 months ago

Does the PR have any schema changes?

Looking good! No breaking changes found.

New resources:

New functions:

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 41.92%. Comparing base (ca05204) to head (c3a6631). Report is 1 commits behind head on master.

Files Patch % Lines
provider/pkg/schema/gen.go 0.00% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1675 +/- ## ========================================== - Coverage 41.94% 41.92% -0.02% ========================================== Files 35 35 Lines 4706 4708 +2 ========================================== Hits 1974 1974 - Misses 2532 2533 +1 - Partials 200 201 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.