search

pulumi / pulumi-aws-native

AWS Native Provider for Pulumi
Apache License 2.0
95 stars 17 forks source link

Extend CustomResource interface to pass state for Update and Delete #1801

Closed flostadler closed 2 weeks ago

flostadler commented 2 weeks ago

Previously the Update and Delete methods for Custom Resources did not require access to the current state, but this is a common requirement for updating and deleting resources.

This is also needed for supporting CloudFormation Custom Resources as those require access to state in order to complete updates and deletions.

relates to https://github.com/pulumi/pulumi-cdk/issues/109

github-actions[bot] commented 2 weeks ago

Does the PR have any schema changes?

Looking good! No breaking changes found. No new resources/functions.

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 45.43%. Comparing base (2962615) to head (4df10f6). Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
provider/pkg/resources/extension_resource.go 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1801 +/- ## ========================================== + Coverage 45.40% 45.43% +0.03% ========================================== Files 38 38 Lines 5883 5887 +4 ========================================== + Hits 2671 2675 +4 Misses 2989 2989 Partials 223 223 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

t0yv0 commented 2 weeks ago

Update must have access to state . This looks like it is fixing an important omission. 🚢