Closed flostadler closed 2 weeks ago
Looking good! No breaking changes found. No new resources/functions.
Attention: Patch coverage is 92.50000%
with 3 lines
in your changes missing coverage. Please review.
Project coverage is 46.78%. Comparing base (
eafde1c
) to head (4cd4ddb
). Report is 1 commits behind head on master.
Files with missing lines | Patch % | Lines |
---|---|---|
provider/pkg/naming/convert.go | 90.00% | 2 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This change adds utility methods needed for supporting CloudFormation custom resources.
The main part of this change is a method for deeply converting all primitive values in a
map[string]interface{}
to strings. This is needed because CloudFormation has this behavior: https://github.com/aws-cloudformation/cloudformation-coverage-roadmap/issues/1037