search

pulumi / pulumi-aws-native

AWS Native Provider for Pulumi
Apache License 2.0
95 stars 17 forks source link

Retry GetResource NotFound when creating #1809

Closed t0yv0 closed 2 weeks ago

t0yv0 commented 2 weeks ago

Introduces a retry for NotFound errors from GetResource executed right after Create.

Based on the logs from our CI runs we suspect eventual consistency in AWS may cause some resources to fail with NotFound in Get even after WaitForResourceOpCompletion succeeded.

Relates: pulumi/pulumi-aws-native#1186

github-actions[bot] commented 2 weeks ago

Does the PR have any schema changes?

Looking good! No breaking changes found. No new resources/functions.

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 90.32258% with 3 lines in your changes missing coverage. Please review.

Project coverage is 45.67%. Comparing base (91e1b65) to head (b594242). Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
provider/pkg/client/client.go 90.32% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1809 +/- ## ========================================== + Coverage 45.44% 45.67% +0.22% ========================================== Files 38 38 Lines 5886 5916 +30 ========================================== + Hits 2675 2702 +27 - Misses 2988 2991 +3 Partials 223 223 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.