search

pulumi / pulumi-aws-native

AWS Native Provider for Pulumi
Apache License 2.0
95 stars 17 forks source link

`AWS::GameLift::ContainerGroupDefinition` missing `ContainerDefinitions`, `TotalMemoryLimitMebibytes` and `TotalVcpuLimit` property #1819

Open flostadler opened 1 week ago

flostadler commented 1 week ago

AWS::GameLift::ContainerGroupDefinition started missing the ContainerDefinitions, TotalMemoryLimitMebibytes and TotalVcpuLimit properties in the CloudFormation schema. Additionally the docs mention the resource is not available even though the API says it is (marked as public/live). This change would break the resource because TotalMemoryLimitMebibytes and TotalVcpuLimit are required properties.

I reached out to AWS about this issue: https://github.com/aws-cloudformation/cloudformation-coverage-roadmap/issues/2180.

Currently this is blocking pulling in new changes from CloudControl (unless we accept the breaking changes). There's no other important changes in the schema so far.

flostadler commented 1 week ago

Calling CloudControl with a create request returns the following progress event:

"ProgressEvent": {
        "TypeName": "AWS::GameLift::ContainerGroupDefinition",
        "Identifier": "Repro",
        "RequestToken": "bccccfba-13a4-4f6b-9816-44f08b86d623",
        "Operation": "CREATE",
        "OperationStatus": "FAILED",
        "EventTime": "2024-11-12T11:45:05.813000+01:00",
        "StatusMessage": "The Amazon GameLift Containers feature is under improvement. (Service: GameLift, Status Code: 400, Request ID: 1cec4603-4be6-4839-9d9d-348d44425379)",
        "ErrorCode": "AccessDenied"
    }

The CloudFormation API seems to incorrectly label the resource as supported.

We should be good to go forward with the schema change then, but ideally we need some way to mark existing resources as not supported if CloudFormation is incorrectly specifying they are supported.