search

pulumi / pulumi-aws-native

AWS Native Provider for Pulumi
Apache License 2.0
95 stars 17 forks source link

Add autonaming overlay #1828

Closed corymhall closed 1 week ago

corymhall commented 1 week ago

Most resources have some limits on what the resource name can be. Unfortunately a lot of those limits are not currently stored in the CloudFormation schema.

This PR introduces a new schema overlay where we can manually store min/max length constraints for resource names.

This is the first step in addressing #1816. I will follow this up with another PR to trim names to fit within the constraints.

re #1816, re https://github.com/pulumi/pulumi-cdk/issues/62

github-actions[bot] commented 1 week ago

Does the PR have any schema changes?

Looking good! No breaking changes found. No new resources/functions.

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 33.33333% with 22 lines in your changes missing coverage. Please review.

Project coverage is 49.62%. Comparing base (4872ad6) to head (1ed7447). Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
provider/cmd/pulumi-gen-aws-native/main.go 33.33% 22 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1828 +/- ## ========================================== - Coverage 49.67% 49.62% -0.06% ========================================== Files 43 43 Lines 6562 6591 +29 ========================================== + Hits 3260 3271 +11 - Misses 3059 3077 +18 Partials 243 243 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.