Add configuration for controlling the autonaming behavior

corymhall commented 1 week ago

This PR adds some new functionality to control the auto naming behavior. The new behavior lives behind a provider config variable and must be explicitly enabled by the user. The existing behavior will remain the default behavior of the provider.

What's new

autoTrim: When this is set to true the provider will automatically trim the generated name to fit within the maxLength requirement.
randomSuffixMinLength: Set this to control the minimum length of the random suffix that is generated. This is especially useful in combination with autoTrim to ensure that you still end up with unique names (e.g. a random suffix of 1 character is not very unique)

closes https://github.com/pulumi/pulumi-aws-native/issues/1816, re https://github.com/pulumi/pulumi-cdk/issues/62

github-actions[bot] commented 1 week ago

Does the PR have any schema changes?

Looking good! No breaking changes found. No new resources/functions.

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 95.91837% with 2 lines in your changes missing coverage. Please review.

Project coverage is 49.96%. Comparing base (4111ee4) to head (7fad16d). Report is 2 commits behind head on master.

Files with missing lines	Patch %	Lines
provider/pkg/provider/provider.go	85.71%	0 Missing and 1 partial :warning:
provider/pkg/resources/extension_resource.go	0.00%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1831 +/- ## ========================================== + Coverage 49.62% 49.96% +0.34% ========================================== Files 43 43 Lines 6591 6636 +45 ========================================== + Hits 3271 3316 +45 Misses 3077 3077 Partials 243 243 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

t0yv0 commented 1 week ago

Added https://github.com/pulumi/pulumi-aws-native/issues/1833 but out of scope of this PR.... Looks like we are consuming GetVariables still in this provider.

t0yv0 commented 1 week ago

Assuming here https://github.com/pulumi/pulumi/discussions/17592 is not quite ready for prime time so we need this now.

pulumi / pulumi-aws-native

Add configuration for controlling the autonaming behavior #1831

Does the PR have any schema changes?

Codecov Report