search

pulumi / pulumi-aws-native

AWS Native Provider for Pulumi
Apache License 2.0
95 stars 17 forks source link

Extend metadata with descriptors of CF Ref handling #1836

Closed t0yv0 closed 3 days ago

t0yv0 commented 6 days ago

CloudFormation Ref intrinsic behavior varies from resource to resource. This change is an attempt to schematize behavior and expose is in the provider metadata. One intended use case is pulumi/pulumi-cdk CF emulator.

This change implies the ref-db.json becomes the source of truth for this metadata and we maintain it as well as possible.

About 1/2 of CF resources are currently covered in the file, including 81 of the top used resources (https://github.com/pulumi/pulumi-cdk/issues/237). Data cleaning and data label attachment helper code is included but is not intended to be used in production but only to maintain ref-db.json.

github-actions[bot] commented 6 days ago

Does the PR have any schema changes?

Looking good! No breaking changes found. No new resources/functions.

codecov[bot] commented 6 days ago

Codecov Report

Attention: Patch coverage is 2.63158% with 407 lines in your changes missing coverage. Please review.

Project coverage is 47.13%. Comparing base (6007c03) to head (eb0829b). Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
provider/tools/ref-parser/game.go 0.00% 118 Missing :warning:
provider/tools/ref-parser/main.go 0.00% 112 Missing :warning:
provider/tools/ref-parser/autolabel.go 0.00% 76 Missing :warning:
provider/tools/ref-parser/reports.go 0.00% 43 Missing :warning:
provider/tools/ref-parser/schema.go 0.00% 24 Missing :warning:
provider/pkg/refdb/refdb.go 0.00% 18 Missing :warning:
provider/cmd/pulumi-gen-aws-native/main.go 0.00% 6 Missing :warning:
provider/pkg/schema/gen.go 45.45% 5 Missing and 1 partial :warning:
provider/tools/ref-parser/cat.go 60.00% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1836 +/- ## ========================================== - Coverage 49.96% 47.13% -2.84% ========================================== Files 43 50 +7 Lines 6636 7050 +414 ========================================== + Hits 3316 3323 +7 - Misses 3077 3483 +406 - Partials 243 244 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features: