search

pulumi / pulumi-aws-native

AWS Native Provider for Pulumi
Apache License 2.0
92 stars 17 forks source link

WebACLCustomResponseBodiesArgs type not implemented #734

Closed smirco-globality closed 6 months ago

smirco-globality commented 1 year ago

Hello!

Issue details

wafv2 WebACL has a parameter for custom_response_bodies accepting type WebACLCustomResponseBodiesArgs however this input type appears to simply be a stub https://github.com/pulumi/pulumi-aws-native/blob/master/sdk/python/pulumi_aws_native/wafv2/_inputs.py#L2550-L2557

This makes it impossible to manage custom responses on WafACLs

roothorp commented 1 year ago

Hi @smirco-globality, thanks for the issue! I've raised this with the team to be prioritized and added to our work stack.

danielrbradley commented 6 months ago

I believe this has now been fixed in the following PR:

The type of custom_response_bodies is now defined as: https://github.com/pulumi/pulumi-aws-native/blob/b46b6fb7d2867a28f7347025c655c57835ac533d/sdk/python/pulumi_aws_native/wafv2/web_acl.py#L116

with the type definition:

https://github.com/pulumi/pulumi-aws-native/blob/b46b6fb7d2867a28f7347025c655c57835ac533d/sdk/python/pulumi_aws_native/wafv2/_inputs.py#L3034-L3060