pulumi / pulumi-aws

An Amazon Web Services (AWS) Pulumi resource package, providing multi-language access to AWS
Apache License 2.0
458 stars 155 forks source link

EKS control plane logging not working as expected and documentation issue #1882

Open unludo opened 2 years ago

unludo commented 2 years ago

Hello!

Issue details

I follow this to enable EKS control plane logging https://www.pulumi.com/registry/packages/aws/api-docs/eks/cluster/#enabling-control-plane-logging

When applying this, 2 logs groups are created, the first one created as a dedicated resource is not used at all and seems useless. Another cloudwatch log group is created with no expiration, this one contains the awaited EKS logs.

Documentation does not seem correct. Additionally an enhancement would be to be able to expire the log group actually producing the logs.

Steps to reproduce

Follow https://www.pulumi.com/registry/packages/aws/api-docs/eks/cluster/#enabling-control-plane-logging

Expected:

Having only one log group with wanted expiration.

Actual:

2 log groups, one useless, the other one has no expiration

mikhailshilkov commented 2 years ago

Hi @unludo thank you for reporting this. The AWS provider is based on the Terraform provider, including the docs examples. I believe the source example here will have the same problems. It's worth reporting it to the TF provider repo so that it's fixed/improved everywhere.