search

pulumi / pulumi-aws

An Amazon Web Services (AWS) Pulumi resource package, providing multi-language access to AWS
Apache License 2.0
428 stars 150 forks source link

rum.AppMonitor - customEvents property is not considered during resource update #2350

Open lukasz-giants opened 1 year ago

lukasz-giants commented 1 year ago

What happened?

After update to pulumi-aws "5.29.0" and add to definition of rum.AppMonitor -> customEvents -> status "ENABLED" pulumi don't see the diff while updating resource on AWS. It is not working either from DISABLED to ENABLED or ENABLED to DISABLED. Work only when we create a new resource but then again when I try to change this value it stay as it was created originally.

Expected Behavior

Pulumi responds to value changes for AppMonitorCustomEvents (customEvents)

Steps to reproduce

  1. Create some RUM AppMonitor (with custom event enabled or disabled)
  2. Try to change only custom event value

Output of pulumi about

Pulumi is running on Azure DevOps Agent

Task : Pulumi Azure Pipelines Task Description : Azure Pipelines task extension for running Pulumi apps. Version : 1.1.2 Author : Pulumi Help : Join us on Slack at https://slack.pulumi.com./ Downloading: https://get.pulumi.com/releases/sdk/pulumi-v3.53.1-linux-x64.tar.gz Caching tool: pulumi 3.53.1 x64 /home/vsts/work/_temp/7f8bce3d-441b-4e45-bcb4-3c18fc11bd72/pulumi/pulumi version v3.53.1

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction. To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

thomas11 commented 1 year ago

Hi @lukasz-giants, thanks for reporting this. Can you clarify whether this worked for you in a version of pulumi-aws before 5.29?

lukasz-giants commented 1 year ago

Hi @thomas11, this feature wasn't be available before 5.29. Support for custom event was introduce in 5.29 and https://github.com/hashicorp/terraform-provider-aws/blob/v4.51.0/CHANGELOG.md