pulumi / pulumi-aws

An Amazon Web Services (AWS) Pulumi resource package, providing multi-language access to AWS
Apache License 2.0
459 stars 155 forks source link

Kinesis Firehose ExtendedS3Configuration support for FileExtension #3479

Closed dygfloyd closed 2 weeks ago

dygfloyd commented 7 months ago

Hello!

Issue details

Kinesis Firehose ExtendedS3Configuration current does not support the optional FileExtension property. This property is described in the AWS Destination Settings documentation. This causes issues when you are trying to import files in S3 into other systems that require specific file extensions. For example, Datadog log rehydration only supports files with the extension .json.gz.

iwahbe commented 7 months ago

Hi @dygfloyd. Thanks for letting us know about this. The pulumi-aws provider is bridged from https://github.com/hashicorp/terraform-provider-aws. The best way to get this feature added is to open an issue there.

dygfloyd commented 7 months ago

I posted a feature request in that repo as well. https://github.com/hashicorp/terraform-provider-aws/issues/35989 Unfortunately, I am unfamiliar with the terraform provider so if anyone has any details they can add to the request, that would be great.

dygfloyd commented 7 months ago

Looks like there was a duplicate ticket and this feature was added a couple of days ago: https://github.com/hashicorp/terraform-provider-aws/pull/35969

iwahbe commented 7 months ago

Great. Then pulumi-aws will pick up the feature shortly after terraform-provider-aws's next release.

mikhailshilkov commented 2 weeks ago

Closing as implemented upstream in https://github.com/hashicorp/terraform-provider-aws/issues/35957