It appears that ./upstream implements go generate code generation driven by names_data.csv.
Running the following commands:
make upstream.rebase
cd upstream
# `make gen` could be interesing but appears not to work well at the moment
# instead just run the first non-rm part from the `gen` target in `GNUMakefile`
go generate ./...
The expectation is that the checked in code will be consistent with the results of re-generating it but it appears not to be the case:
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git restore <file>..." to discard changes in working directory)
modified: internal/conns/awsclient_gen.go
modified: internal/service/acm/service_package_gen.go
modified: internal/service/ecr/service_package_gen.go
modified: internal/service/elasticache/service_package_gen.go
modified: internal/service/rds/service_package_gen.go
modified: internal/service/redshift/service_package_gen.go
It appears that ./upstream implements
go generate
code generation driven bynames_data.csv
.Running the following commands:
The expectation is that the checked in code will be consistent with the results of re-generating it but it appears not to be the case:
Specific example:
Worth checking if this ends up creating end-user issues.