pulumi / pulumi-aws

An Amazon Web Services (AWS) Pulumi resource package, providing multi-language access to AWS
Apache License 2.0
465 stars 157 forks source link

Deprecate EKS cluster property `defaultAddonsToRemoves` in favor of `bootstrapSelfManagedAddons` #4755

Open flostadler opened 1 week ago

flostadler commented 1 week ago

The defaultAddonsToRemove property was introduced to EKS cluster configuration to allow bootstrapping clusters without AWS's default components (coredns, vpc-cni, kube-proxy). This was implemented in a patch, through a workaround where the provider would:

  1. Create an EKS addon on cluster creation
  2. Delete it immediately after
  3. This effectively brought the cluster components under Pulumi's management before destroying them

Current Situation

AWS has now introduced native support for this functionality through the bootstrapSelfManagedAddons flag, which creates a blank cluster without default components.

Key differences:

Proposed Changes

  1. Mark defaultAddonsToRemove as deprecated
  2. Remove the property in the next major version

Required Investigation

Before proceeding with deprecation:

  1. Analyze current usage patterns of defaultAddonsToRemove
    • Identify how users are utilizing the selective removal capability
    • Determine if there are common patterns that would be broken by moving to an all-or-nothing approach
  2. Evaluate potential migration paths for users who need selective addon removal
  3. Consider if we need to maintain both options or if AWS's solution sufficiently covers all use cases

References

t0yv0 commented 1 week ago

There was some pushback on https://github.com/pulumi/pulumi-aws/issues/3009 before but I think what was missing is allowing users to still not get the addons wihch is now made available with bootstrapSelfManagedAddons. Thanks for filing!