search

pulumi / pulumi-awsx

AWS infrastructure best practices in component form!
https://www.pulumi.com/docs/guides/crosswalk/aws/
Apache License 2.0
222 stars 104 forks source link

aws.ec2.getSubnetIds should return type #358

Open jchannon opened 5 years ago

jchannon commented 5 years ago

When calling const subnetsids = pulumi.output( aws.ec2.getSubnetIds({vpcId: primaryVpcId,})); it would be helpful if the ids property contained the type of subnet it is eg/public,private,isolated

lukehoban commented 5 years ago

These concepts of public, private and isolated are things that are not well defined at the pure AWS layer, and are instead part of the awsx abstraction around VPCs.

I can imagine we might be able to add helpers to introspect an AWS subnet and determine which of thesr it was, but that would be in awsx helpers.

I’ll move this to that repo.

CyrusNajmabadi commented 5 years ago

Right. Note that you should be able to use awsx.ecs.getSubnet to get a value back that you can check the tags: of. Pulumi should be creating a tag called type there.

We can def look into making this easier to obtain!